[webkit-reviews] review granted: [Bug 172084] Unused lambda capture in JSContextGroupAddMarkingConstraint() : [Attachment 310060] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 172084: Unused lambda capture in JSContextGroupAddMarkingConstraint()
https://bugs.webkit.org/show_bug.cgi?id=172084

Attachment 310060: Patch

https://bugs.webkit.org/attachment.cgi?id=310060&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 310060
  --> https://bugs.webkit.org/attachment.cgi?id=310060
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310060&action=review

>> Source/JavaScriptCore/API/JSMarkingConstraintPrivate.cpp:78
>> +	    [constraintCallback, userData]
> 
> I'm not sure whether this is some magic to make GC work, so if the &vm lambda
needs to stay, we can use UNUSED_PARAM(&vm) in the body to silence the warning.

Doesn't seem like it to me.