[webkit-reviews] review denied: [Bug 172081] [Win] Correct OS(WINDOWS) and PLATFORM(WIN) compiler guards : [Attachment 310048] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Daewoong Jang
<daewoong.jang at navercorp.com>'s request for review:
Bug 172081: [Win] Correct OS(WINDOWS) and PLATFORM(WIN) compiler guards
https://bugs.webkit.org/show_bug.cgi?id=172081

Attachment 310048: Patch

https://bugs.webkit.org/attachment.cgi?id=310048&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 310048
  --> https://bugs.webkit.org/attachment.cgi?id=310048
Patch

r- because ...

According to Platform.h:
...
#elif OS(WINDOWS)
#define WTF_PLATFORM_WIN 1
#endif

Hence, if OS(WINDOWS), then PLATFORM(WIN) is always true.  The 2 are always
tied together it seems.  So, why is that not sufficient?