[webkit-reviews] review granted: [Bug 172067] Drop uses of PassRefPtr in WebKit/win : [Attachment 310018] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 172067: Drop uses of PassRefPtr in WebKit/win
https://bugs.webkit.org/show_bug.cgi?id=172067

Attachment 310018: Patch

https://bugs.webkit.org/attachment.cgi?id=310018&action=review




--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 310018
  --> https://bugs.webkit.org/attachment.cgi?id=310018
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310018&action=review

r=me with a nit.

> Source/WebKit/win/Plugins/PluginDatabase.cpp:528
> +	   auto package = PluginPackage::createPackageFromCache(path,
lastModified, name, desc, mimeDesc);

This becomes Ref<>, so the following `package && ...`'s meaning is changed. We
can drop `package` boolean check, right?