[webkit-reviews] review granted: [Bug 172045] Null deref under WebContentReader::readURL when interacting with a file URL : [Attachment 309940] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 172045: Null deref under WebContentReader::readURL when interacting with a
file URL
https://bugs.webkit.org/show_bug.cgi?id=172045

Attachment 309940: Patch

https://bugs.webkit.org/attachment.cgi?id=309940&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 309940
  --> https://bugs.webkit.org/attachment.cgi?id=309940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309940&action=review

> Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:550
> +    EXPECT_WK_STREQ("<null>", [webView
stringByEvaluatingJavaScript:@"editor.querySelector('a')"]);

Nit - Could we make this EXPECT_FALSE([[webView
stringByEvaluatingJavaScript:@"!!editor.querySelector('a')"] boolValue])
instead?