[webkit-reviews] review granted: [Bug 171775] WorkerRunLoop::Task::performTask() should check !scriptController->isTerminatingExecution(). : [Attachment 309911] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted  review:
Bug 171775: WorkerRunLoop::Task::performTask() should check
!scriptController->isTerminatingExecution().
https://bugs.webkit.org/show_bug.cgi?id=171775

Attachment 309911: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=309911&action=review




--- Comment #35 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 309911
  --> https://bugs.webkit.org/attachment.cgi?id=309911
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=309911&action=review

> Source/JavaScriptCore/runtime/ExceptionScope.cpp:59
> +    auto currentStack =
std::unique_ptr<StackTrace>(StackTrace::captureStackTrace(100, 1));

Lets make this an option since there are multiple places that use the literal
"100"

> Source/WebCore/ChangeLog:13
> +	   As a result, before run loop is terminate, the worker thread may
observe the

terminate => terminated

> Source/WebCore/ChangeLog:20
> +	   We'll fix the above race by changing
WorkerRunLoop::Task::performTask() to check

I don't understand how this is a race. Can you explain?