[webkit-reviews] review granted: [Bug 172024] [Readable Streams API] Add ReadableStreamBYOBReader closed getter : [Attachment 309883] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 12 12:15:19 PDT 2017


youenn fablet <youennf at gmail.com> has granted Romain Bellessort
<romain.wkt at gmail.com>'s request for review:
Bug 172024: [Readable Streams API] Add ReadableStreamBYOBReader closed getter
https://bugs.webkit.org/show_bug.cgi?id=172024

Attachment 309883: Patch

https://bugs.webkit.org/attachment.cgi?id=309883&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 309883
  --> https://bugs.webkit.org/attachment.cgi?id=309883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309883&action=review

> LayoutTests/streams/readable-stream-byob-reader.js:126
> +

All these tests seem like good candidates for WPT.
Shouldn't they be upstreamed?

> LayoutTests/streams/readable-stream-byob-reader.js:140
> +    return reader.closed.then(

It would be cool if we could do a one liner like: return promise_resolves(test,
undefined, reader.close)


More information about the webkit-reviews mailing list