[webkit-reviews] review granted: [Bug 172023] Add UIClient callback for when picture-in-picture is activated. : [Attachment 309920] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 172023: Add UIClient callback for when picture-in-picture is activated.
https://bugs.webkit.org/show_bug.cgi?id=172023

Attachment 309920: Patch

https://bugs.webkit.org/attachment.cgi?id=309920&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309920
  --> https://bugs.webkit.org/attachment.cgi?id=309920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309920&action=review

> Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:373
> +    m_page->uiClient().setHasVideoInPictureInPicture(m_page,
videoFullscreenMode & MediaPlayerEnums::VideoFullscreenModePictureInPicture);

Do we always want to call the UI client, even when the PiP mode doesn't change?

> Source/WebKit2/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:502
> +    m_page->uiClient().setHasVideoInPictureInPicture(m_page, mode &
MediaPlayerEnums::VideoFullscreenModePictureInPicture);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:131
> +    sleep(1); // Wait for PIPAgent to launch, or it won't call -pipDidClose:
callback.

Is 1 second always enough, even on loaded bots?