[webkit-reviews] review denied: [Bug 172023] Add UIClient callback for when picture-in-picture is activated. : [Attachment 309913] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 172023: Add UIClient callback for when picture-in-picture is activated.
https://bugs.webkit.org/show_bug.cgi?id=172023

Attachment 309913: Patch

https://bugs.webkit.org/attachment.cgi?id=309913&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309913
  --> https://bugs.webkit.org/attachment.cgi?id=309913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309913&action=review

> Source/WebKit2/UIProcess/API/APIUIClient.h:82
> +    virtual void setPictureInPictureActive(WebKit::WebPageProxy*, bool) { }

I think "active" is too vague here. It could be taken to mean that the PIP
window was brought to the front. Maybe setIsShowingPictureInPicture or
something?