[webkit-reviews] review granted: [Bug 172007] Drop remaining uses of PassRefPtr under platform/ : [Attachment 309846] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 11 20:03:53 PDT 2017


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 172007: Drop remaining uses of PassRefPtr under platform/
https://bugs.webkit.org/show_bug.cgi?id=172007

Attachment 309846: Patch

https://bugs.webkit.org/attachment.cgi?id=309846&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 309846
  --> https://bugs.webkit.org/attachment.cgi?id=309846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309846&action=review

rs=me

> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:147
> +static bool MockSourceBufferPrivateHasAudio(MockSourceBufferPrivate*
sourceBuffer)

Maybe MockSourceBufferPrivate&?

> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:157
> +static bool MockSourceBufferPrivateHasVideo(MockSourceBufferPrivate*
sourceBuffer)

Maybe MockSourceBufferPrivate&?


More information about the webkit-reviews mailing list