[webkit-reviews] review granted: [Bug 172010] RenderImageResource::hasImage is redundant and RenderImageResourceStyleImage's override is incorrect. : [Attachment 309849] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 172010: RenderImageResource::hasImage is redundant and
RenderImageResourceStyleImage's override is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=172010

Attachment 309849: Patch

https://bugs.webkit.org/attachment.cgi?id=309849&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309849
  --> https://bugs.webkit.org/attachment.cgi?id=309849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309849&action=review

> LayoutTests/fast/images/missing-content-image-crash.html:19
> +missingImage.style.content =
"url('http://fakeurl.with-missing.jpg/missing.jpg')";

I think we avoid tests that make random http requests, even if they are to
bogus hosts. Not sure if we have canonical test host (example.com?).