[webkit-reviews] review granted: [Bug 171977] Stop using PassRefPtr in platform/graphics : [Attachment 309793] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 11 15:31:17 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 171977: Stop using PassRefPtr in platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=171977

Attachment 309793: Patch

https://bugs.webkit.org/attachment.cgi?id=309793&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 309793
  --> https://bugs.webkit.org/attachment.cgi?id=309793
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309793&action=review

> Source/WebCore/platform/graphics/filters/FilterOperation.h:182
> +	   return *static_cast<FilterOperation*>(nullptr);

I would prefer dereferencing this.  Dereferencing nullptr feels really bad.


More information about the webkit-reviews mailing list