[webkit-reviews] review granted: [Bug 171815] [iOS] Unset active media capture source when stopped capturing : [Attachment 309670] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 171815: [iOS] Unset active media capture source when stopped capturing
https://bugs.webkit.org/show_bug.cgi?id=171815

Attachment 309670: Patch

https://bugs.webkit.org/attachment.cgi?id=309670&action=review




--- Comment #22 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 309670
  --> https://bugs.webkit.org/attachment.cgi?id=309670
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309670&action=review

> Source/WebCore/ChangeLog:15
> +	   Updating all capture sources accordingly.
> +	   Ensuring sources are no longer considered as active sources when
being destroyed.
> +	   Adding support for mock sources and introducing m_isProducingData
for them as well.

Nit: "Updating" => "Update", "Ensuring" => "Ensure", "Adding" => "Add"

> Source/WebCore/ChangeLog:21
> +	   Updating WebRTC outgoing source classes to handle the case of
replaced track and resetting the enabled/mute
> +	   state according the new source.
> +
> +	   Updating the way we handle timestamps for audio data. We now
consider that we read/write as a flow.
> +	   This allows smooth audio track replacing.

Nit: "Updating"