[webkit-reviews] review granted: [Bug 171961] WebGLRenderingContext should implement WebGLRenderingContextBase : [Attachment 309773] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 171961: WebGLRenderingContext should implement WebGLRenderingContextBase
https://bugs.webkit.org/show_bug.cgi?id=171961

Attachment 309773: Patch

https://bugs.webkit.org/attachment.cgi?id=309773&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 309773
  --> https://bugs.webkit.org/attachment.cgi?id=309773
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309773&action=review

> Source/WebCore/bindings/js/JSDocumentCustom.cpp:160
> +    if (is<WebGL2RenderingContext>(*context))
> +	   return toJS(&state, globalObject(),
downcast<WebGL2RenderingContext>(*context));

Should this be in a WEBGL2 #ifdef? Do we need a WEBGL2 #ifdef at all?

> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:74
> +	       if (is<WebGL2RenderingContext>(*context))
> +		   return
toJS<IDLNullable<IDLInterface<WebGL2RenderingContext>>>(state, *globalObject(),
static_cast<WebGL2RenderingContext*>(context));

Should this be in a WEBGL2 #ifdef? Do we need a WEBGL2 #ifdef at all?

> Source/WebCore/html/canvas/WebGL2RenderingContext.idl:340
>      // WebGL2:

This comment can probably also go.