[webkit-reviews] review granted: [Bug 171950] [CMake] Add HAVE check for regex.h : [Attachment 309741] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 11 13:27:02 PDT 2017
Michael Catanzaro <mcatanzaro at igalia.com> has granted Don Olmstead
<don.olmstead at am.sony.com>'s request for review:
Bug 171950: [CMake] Add HAVE check for regex.h
https://bugs.webkit.org/show_bug.cgi?id=171950
Attachment 309741: Patch
https://bugs.webkit.org/attachment.cgi?id=309741&action=review
--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 309741
--> https://bugs.webkit.org/attachment.cgi?id=309741
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=309741&action=review
> Source/JavaScriptCore/runtime/ConfigFile.cpp:43
> +#if OS(UNIX) || OS(DARWIN)
As discussed in #webkit, isn't the || OS(DARWIN) redundant here?
More information about the webkit-reviews
mailing list