[webkit-reviews] review denied: [Bug 170640] Do not delete asynchronously decoded frames for large images if their clients are in the viewport : [Attachment 309730] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 170640: Do not delete asynchronously decoded frames for large images if
their clients are in the viewport
https://bugs.webkit.org/show_bug.cgi?id=170640

Attachment 309730: Patch

https://bugs.webkit.org/attachment.cgi?id=309730&action=review




--- Comment #42 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309730
  --> https://bugs.webkit.org/attachment.cgi?id=309730
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309730&action=review

> Source/WebCore/platform/graphics/ImageObserver.h:48
> +    virtual bool isAnyClientVisible(const Image&) = 0;

I don't think client visibility should be the thing being asked about in this
API. This should be more like "is it OK to discard decoded data". It's the
RenderElement's job to decide that throwing away is related to visibility.

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:311
> +    if (index == frameCount() - 1)
> +	   return CGImageSourceGetStatus(m_nativeDecoder.get()) ==
kCGImageStatusComplete;

This needs a comment.