[webkit-reviews] review granted: [Bug 171974] Unify hasTouchScrollableOverflow/needsCompositedScrolling concepts : [Attachment 309716] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 11 11:19:36 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 171974: Unify hasTouchScrollableOverflow/needsCompositedScrolling concepts
https://bugs.webkit.org/show_bug.cgi?id=171974

Attachment 309716: Patch

https://bugs.webkit.org/attachment.cgi?id=309716&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309716
  --> https://bugs.webkit.org/attachment.cgi?id=309716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309716&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:2191
>> +bool RenderLayer::useCoordinatedScrolling() const
> 
> Would RenderLayer::usesCoordinatedScrolling be a better name for this?

Yes!

Hopefully this won't be confused with coordinated graphics. Maybe
"acceleratedScrolling"?


More information about the webkit-reviews mailing list