[webkit-reviews] review granted: [Bug 171949] Resource Load Statistics: Enable configuration through preferences : [Attachment 309664] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 171949: Resource Load Statistics: Enable configuration through preferences
https://bugs.webkit.org/show_bug.cgi?id=171949

Attachment 309664: Patch

https://bugs.webkit.org/attachment.cgi?id=309664&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 309664
  --> https://bugs.webkit.org/attachment.cgi?id=309664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309664&action=review

> Source/WebCore/loader/ResourceLoadObserver.cpp:437
> +    if (seconds > 0)

Should the callee check this?  Maybe an assertion?  We have checks in the
caller.

> Source/WebKit2/UIProcess/Cocoa/WebResourceLoadStatisticsManagerCocoa.mm:43
> +	   // Max 30 days in seconds.
> +	   if (timeToLiveUserInteraction > 0 && timeToLiveUserInteraction <=
2592000)

const size_t secondsPerDay = 24 * 3600;
... && timeToLiveUserInteraction <= 30 * secondsPerDay)

> Source/WebKit2/UIProcess/Cocoa/WebResourceLoadStatisticsManagerCocoa.mm:48
> +	   // Max 1 day in seconds.
> +	   if (timeToLiveCookiePartitionFree > 0 &&
timeToLiveCookiePartitionFree <= 86400)

... timeToLiveCookiePartitionFree <= 1 * secondsPerDay)