[webkit-reviews] review granted: [Bug 170935] [selectors4] :focus-within tests using shadow DOM don't pass on WK1 : [Attachment 309033] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 170935: [selectors4] :focus-within tests using shadow DOM don't pass on WK1
https://bugs.webkit.org/show_bug.cgi?id=170935

Attachment 309033: Patch

https://bugs.webkit.org/attachment.cgi?id=309033&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 309033
  --> https://bugs.webkit.org/attachment.cgi?id=309033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309033&action=review

>
LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-display
-none-001.html:9
> +<script src="../../../../../resources/testharnessreport.js"></script>

This is one small difference here of importing from the hidden clone or from
your specific clone.
With the hidden clone, testharness links would remain the same.
We might want to switch to that type of links but we are not doing so yet.

Also, going from the clone created by the script ensures that you only import
changes from WPT master.