[webkit-reviews] review granted: [Bug 170432] [GTK] GIF images are not properly loaded the first time : [Attachment 309704] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 170432: [GTK] GIF images are not properly loaded the first time
https://bugs.webkit.org/show_bug.cgi?id=170432

Attachment 309704: Patch

https://bugs.webkit.org/attachment.cgi?id=309704&action=review




--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 309704
  --> https://bugs.webkit.org/attachment.cgi?id=309704
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309704&action=review

Amazing!

> Source/WebCore/platform/graphics/ImageFrameCache.cpp:482
> +#if !USE(CG)
> +    if (m_frames.isEmpty() && isDecoderAvailable())
> +	   return m_decoder->size();
> +#endif

I think we should add a comment here briefly mentioning the tricky issue
explained on the changelog for the next developer that touches this code.