[webkit-reviews] review requested: [Bug 170690] WebAssembly: report Memory usage to GC : [Attachment 309699] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 11 00:32:32 PDT 2017


JF Bastien <jfbastien at apple.com> has asked  for review:
Bug 170690: WebAssembly: report Memory usage to GC
https://bugs.webkit.org/show_bug.cgi?id=170690

Attachment 309699: patch

https://bugs.webkit.org/attachment.cgi?id=309699&action=review




--- Comment #2 from JF Bastien <jfbastien at apple.com> ---
Created attachment 309699

  --> https://bugs.webkit.org/attachment.cgi?id=309699&action=review

patch

I'm still not sure this is the right thing. We definitely should tell the GC
about this memory but:

 1. It's more memory than other allocations. Maybe that's the same as
ArrayBuffer and doesn't matter?
 2. We're not sure all pages are dirty, so we could be over-reporting if the
developer over-allocates. We just don't know if they do.

I think these don't matter, and we can adjust if they do, so this patch is
probably right. I'd nonetheless would rather ask and get feedback on these
points.


More information about the webkit-reviews mailing list