[webkit-reviews] review granted: [Bug 171966] Stop using PassRefPtr in platform/audio : [Attachment 309690] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 171966: Stop using PassRefPtr in platform/audio
https://bugs.webkit.org/show_bug.cgi?id=171966

Attachment 309690: Patch

https://bugs.webkit.org/attachment.cgi?id=309690&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 309690
  --> https://bugs.webkit.org/attachment.cgi?id=309690
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309690&action=review

> Source/WebCore/platform/audio/HRTFDatabaseLoader.cpp:57
> +    Ref<HRTFDatabaseLoader> loader = adoptRef(*new
HRTFDatabaseLoader(sampleRate));

We can't use auto here?

> Source/WebCore/platform/audio/mac/AudioBusMac.mm:-57
> -	   RefPtr<AudioBus> bus(createBusFromInMemoryAudioFile([audioData
bytes], [audioData length], false, sampleRate));
> -	   return bus;

This was a strange piece of code!