[webkit-reviews] review granted: [Bug 171954] Web Inspector: RTL: "Elements > Styles - Rules" rule and media query headers should be left aligned : [Attachment 309665] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 10 18:49:31 PDT 2017
Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 171954: Web Inspector: RTL: "Elements > Styles - Rules" rule and media
query headers should be left aligned
https://bugs.webkit.org/show_bug.cgi?id=171954
Attachment 309665: Patch
https://bugs.webkit.org/attachment.cgi?id=309665&action=review
--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 309665
--> https://bugs.webkit.org/attachment.cgi?id=309665
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=309665&action=review
r=me, with comment
> Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js:38
> + this.element.dir = "ltr";
I don't understand why this is needed. Commenting it out doesn't break
anything, as far as I can tell.
More information about the webkit-reviews
mailing list