[webkit-reviews] review granted: [Bug 171944] [iOS] Use memory footprint to dynamically adjust behavior of allocators : [Attachment 309640] Almost done patch for review

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 171944: [iOS] Use memory footprint to dynamically adjust behavior of
allocators
https://bugs.webkit.org/show_bug.cgi?id=171944

Attachment 309640: Almost done patch for review

https://bugs.webkit.org/attachment.cgi?id=309640&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 309640
  --> https://bugs.webkit.org/attachment.cgi?id=309640
Almost done patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=309640&action=review

This looks good to me!

> Source/JavaScriptCore/heap/Heap.cpp:117
> +    size_t memoryFootprint = bmalloc::api::memoryFootprint();

Would be cool if bmalloc::api::memoryFootprint was abstracted in WTF behind
fastMallocMemoryFootprint, or something.

Not super important.

> Source/bmalloc/bmalloc/Heap.cpp:45
> +#if BPLATFORM(IOS)
> +namespace WTF {
> +
> +size_t ramSize();
> +
> +}
> +#endif

Would be a lot better if you moved WTF::ramSize into bmalloc, and then
WTF::ramSize would be a forwarding function that calls bmalloc::api::ramSize or
whatever.