[webkit-reviews] review granted: [Bug 171775] Entry points to the VM should bail if a TerminatedExecutionException is pending. : [Attachment 309644] proposed patch with better fix.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 171775: Entry points to the VM should bail if a
TerminatedExecutionException is pending.
https://bugs.webkit.org/show_bug.cgi?id=171775

Attachment 309644: proposed patch with better fix.

https://bugs.webkit.org/attachment.cgi?id=309644&action=review




--- Comment #18 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 309644
  --> https://bugs.webkit.org/attachment.cgi?id=309644
proposed patch with better fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=309644&action=review

r=me

> Source/WebCore/workers/WorkerThread.cpp:267
> +    // We need to terminate the runLoop before we

Looks like this comment got cut off mid-sentence. I would say "Prevent a while
(1) { } loop from keeping the worker alive forever."