[webkit-reviews] review granted: [Bug 171909] Simplify relationship between Attr and Element now that Attr is childless : [Attachment 309635] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 171909: Simplify relationship between Attr and Element now that Attr is
childless
https://bugs.webkit.org/show_bug.cgi?id=171909

Attachment 309635: Patch

https://bugs.webkit.org/attachment.cgi?id=309635&action=review




--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 309635
  --> https://bugs.webkit.org/attachment.cgi?id=309635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309635&action=review

> Source/WebCore/ChangeLog:18
> +	   Attr::setValueForBindings() wa thus renamed to setValue(). Its
implementation

Typo: wa -> was.

> Source/WebCore/ChangeLog:21
> +	   Element::setAttributeInternal().

Maybe you can put this in the pervious line to make it read better?

> Source/WebCore/dom/Node.cpp:841
> +bool Document::shouldInvalidateNodeListAndCollectionCaches() const

Add inline here?

> Source/WebCore/dom/Node.cpp:850
> +bool Document::shouldInvalidateNodeListAndCollectionCachesForAttribute(const
QualifiedName& attrName) const

Add inline here?