[webkit-reviews] review granted: [Bug 152690] [GTK] JavaScript beforeunload prompt uses title of page to be loaded rather title of current page : [Attachment 309623] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 10 12:39:01 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 152690: [GTK] JavaScript beforeunload prompt uses title of page to be
loaded rather title of current page
https://bugs.webkit.org/show_bug.cgi?id=152690

Attachment 309623: Patch

https://bugs.webkit.org/attachment.cgi?id=309623&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 309623
  --> https://bugs.webkit.org/attachment.cgi?id=309623
Patch

The change looks correct. One nit: I'm not super comfortable with using the
current title without having tested an actual beforeunload prompt. So I would
change the title of this bug, and the title in the changelog to match. I think
you can just remove the word "beforeunload" from the title: "JavaScript prompt
uses title of page to be loaded rather than title of current page." (Oh look, I
forgot a "than" in the original title!)


More information about the webkit-reviews mailing list