[webkit-reviews] review granted: [Bug 171907] Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub : [Attachment 309574] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 171907: Web Inspector: Copy to clipboard fails via
InspectorFrontendHostStub
https://bugs.webkit.org/show_bug.cgi?id=171907

Attachment 309574: Patch

https://bugs.webkit.org/attachment.cgi?id=309574&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 309574
  --> https://bugs.webkit.org/attachment.cgi?id=309574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309574&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js:124
> +	       const textarea = document.createElement("textarea");

Nit: We would typically use `let` instead of const, but it doesn't really
matter.

Our style for when we use `const` tends to be when the value is the equivalent
of a compile time constant. So `const timeToWait = 1000;" but not `const
timeToWait = x * y;`. Maybe we should change that style though.