[webkit-reviews] review canceled: [Bug 171715] AX: Media Controls: Missing labels for the Time Labels. : [Attachment 309450] Patch

[bugzilla-daemon at webkit.org]

James Craig <jcraig at apple.com> has canceled Aaron Chu <aaron_chu at apple.com>'s
request for review:
Bug 171715: AX: Media Controls: Missing labels for the Time Labels.
https://bugs.webkit.org/show_bug.cgi?id=171715

Attachment 309450: Patch

https://bugs.webkit.org/attachment.cgi?id=309450&action=review




--- Comment #7 from James Craig <jcraig at apple.com> ---
Comment on attachment 309450
  --> https://bugs.webkit.org/attachment.cgi?id=309450
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309450&action=review

> Source/WebCore/Modules/modern-media-controls/controls/time-label.js:37
> +	       this.element.setAttribute("aria-roledescription",
timerDescription); 

Let's use aria-label rather than roledescription here.

This seems like a solid attempt at reducing verbosity, but I believe it'd have
some fallout. In a context where role description was unsupported (maybe
Orca/Atk? or iTunes on Windows?), there would no way to distinguish the two
timers.

> Source/WebCore/Modules/modern-media-controls/controls/time-label.js:65
> +		   this.element.setAttribute("aria-label", formattedTime);

I think this label would duplicate the contents, so you'd hear something like
"0:23, 0:23" in some browser+screenreader combinations (timers should speak
both their label and value)

I believe the previous version used:
<span role="timer" aria-label="Remaining">0:23</span>

> LayoutTests/media/modern-media-controls/time-control/time-control.html:36
>
+shouldBeEqualToString("timeControl.elapsedTimeLabel.element.getAttribute('aria
-roledescription')", "Elapsed");
>
+shouldBeEqualToString("timeControl.elapsedTimeLabel.element.getAttribute('role
')", "timer");
>  shouldBe("timeControl.children[1]", "timeControl.scrubber");
>  shouldBe("timeControl.children[2]", "timeControl.remainingTimeLabel");
>
+shouldBeEqualToString("timeControl.remainingTimeLabel.element.getAttribute('ar
ia-roledescription')", "Remaining");
>
+shouldBeEqualToString("timeControl.remainingTimeLabel.element.getAttribute('ro
le')", "timer");

See if you can validate the accessible note properties here rather than the DOM
attributes.