[webkit-reviews] review denied: [Bug 171890] Fix an internal build : [Attachment 309556] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Alex Christensen <achristensen at apple.com>'s request
for review:
Bug 171890: Fix an internal build
https://bugs.webkit.org/show_bug.cgi?id=171890

Attachment 309556: Patch

https://bugs.webkit.org/attachment.cgi?id=309556&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 309556
  --> https://bugs.webkit.org/attachment.cgi?id=309556
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309556&action=review

> Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:112
> -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
> -SOFT_LINK_CLASS(AVKit, AVTouchBarPlaybackControlsProvider)
> -SOFT_LINK_CLASS(AVKit, AVTouchBarScrubber)
> -#else
> +
> +#if __MAC_OS_X_VERSION_MAX_ALLOWED < 101300
>  SOFT_LINK_CLASS(AVKit, AVFunctionBarPlaybackControlsProvider)
>  SOFT_LINK_CLASS(AVKit, AVFunctionBarScrubber)
> -#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
> +#else
> +SOFT_LINK_CLASS(AVKit, AVTouchBarPlaybackControlsProvider)
> +SOFT_LINK_CLASS(AVKit, AVTouchBarScrubber)
> +#endif

Seems wrong to make this decision about which class to load at runtime based on
the SDK used at build time.