[webkit-reviews] review granted: [Bug 171305] Speedometer: Update the Backbone.js implementation to a more recent library version : [Attachment 308181] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Addy Osmani <addyo at chromium.org>'s
request for review:
Bug 171305: Speedometer: Update the Backbone.js implementation to a more recent
library version
https://bugs.webkit.org/show_bug.cgi?id=171305

Attachment 308181: Patch

https://bugs.webkit.org/attachment.cgi?id=308181&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 308181
  --> https://bugs.webkit.org/attachment.cgi?id=308181
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308181&action=review

> PerformanceTests/ChangeLog:7
> +	   Updates the Backbone.js TodoMVC implementation to latest

Add a blink line above this.

> PerformanceTests/ChangeLog:52
> +	   (else):

Are these functions modified? If not, we should just get rid of these inline
comments.

> PerformanceTests/ChangeLog:128
> +	  
(typeof.module.string_appeared_here.typeof.module.exports.string_appeared_here.
true):

Please remove these inline comments if files are simply imported from
somewhere.