[webkit-reviews] review granted: [Bug 171307] Speedometer: Update the AngularJS implementation to a more recent library version : [Attachment 308184] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 9 14:45:55 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Addy Osmani <addyo at chromium.org>'s
request for review:
Bug 171307: Speedometer: Update the AngularJS implementation to a more recent
library version
https://bugs.webkit.org/show_bug.cgi?id=171307

Attachment 308184: Patch

https://bugs.webkit.org/attachment.cgi?id=308184&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 308184
  --> https://bugs.webkit.org/attachment.cgi?id=308184
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308184&action=review

> PerformanceTests/ChangeLog:7
> +	   Updates the AngularJS implementation of TodoMVC to 1.4.x

Add a blank line above this line.

> PerformanceTests/ChangeLog:49
> +	   (isValidDottedPath):

Please remove these inline comments when files are just imported from
somewhere.


More information about the webkit-reviews mailing list