[webkit-reviews] review granted: [Bug 171877] [MediaStream] deviceId constraint doesn't work with getUserMedia : [Attachment 309533] Proposed patch.

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 171877: [MediaStream] deviceId constraint doesn't work with getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=171877

Attachment 309533: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=309533&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 309533
  --> https://bugs.webkit.org/attachment.cgi?id=309533
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=309533&action=review

> Source/WebKit2/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:319
> +	   MediaConstraintsData localAudioConstraintsData =
MediaConstraintsData(audioConstraintsData);
> +	   localAudioConstraintsData.deviceIDHashSalt =
deviceIdentifierHashSalt;
> +
> +	   MediaConstraintsData localVideoConstraintsData =
MediaConstraintsData(videoConstraintsData);
> +	   localVideoConstraintsData.deviceIDHashSalt =
deviceIdentifierHashSalt;
> +
> +	   auto audioConstraints =
MediaConstraintsImpl::create(WTFMove(localAudioConstraintsData));
> +	   auto videoConstraints =
MediaConstraintsImpl::create(WTFMove(localVideoConstraintsData));

Nit: this is really wordy. Could we maybe add some way of creating an Impl with
just a MediaConstraintsData and a salt?