[webkit-reviews] review requested: [Bug 171851] [GTK] Fix compile warnings in CryptoKeyECGCrypt.cpp : [Attachment 309483] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 9 10:09:55 PDT 2017
Michael Catanzaro <mcatanzaro at igalia.com> has asked for review:
Bug 171851: [GTK] Fix compile warnings in CryptoKeyECGCrypt.cpp
https://bugs.webkit.org/show_bug.cgi?id=171851
Attachment 309483: Patch
https://bugs.webkit.org/attachment.cgi?id=309483&action=review
--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 309483
--> https://bugs.webkit.org/attachment.cgi?id=309483
Patch
Actually, I'll make a topic about this on webkit-dev, since we should find a
standard way of handling this very common cause of warnings. I've been fixing
these by adding a RELEASE_ASSERT_NOT_REACHED() in the default case and not
having any code below the switch.
More information about the webkit-reviews
mailing list