[webkit-reviews] review granted: [Bug 171861] Force StaticStringImpl constructor to use the constexpr versions of StringImplShape constructors. : [Attachment 309503] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 171861: Force StaticStringImpl constructor to use the constexpr versions of
StringImplShape constructors.
https://bugs.webkit.org/show_bug.cgi?id=171861

Attachment 309503: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=309503&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 309503
  --> https://bugs.webkit.org/attachment.cgi?id=309503
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=309503&action=review

r=me with nits.

> Source/WTF/wtf/text/StringImpl.h:150
> +    constexpr StringImplShape(unsigned refCount, unsigned length, const char
(&characters)[charactersCount], unsigned hashAndFlags, int)

I like to use enum for these taggings like, CreateSymbolTag in StringImpl.h.

> Source/WTF/wtf/text/StringImpl.h:158
> +    constexpr StringImplShape(unsigned refCount, unsigned length, const
char16_t (&characters)[charactersCount], unsigned hashAndFlags, int)

Ditto.