[webkit-reviews] review granted: [Bug 171850] [GTK] Fix compile warnings in PlatformImageCairo.cpp : [Attachment 309481] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Hyungwook Lee
<hyungwook.lee at navercorp.com>'s request for review:
Bug 171850: [GTK] Fix compile warnings in PlatformImageCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=171850

Attachment 309481: Patch

https://bugs.webkit.org/attachment.cgi?id=309481&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 309481
  --> https://bugs.webkit.org/attachment.cgi?id=309481
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309481&action=review

> Tools/ImageDiff/cairo/PlatformImageCairo.cpp:54
> +	       return readBytes ? CAIRO_STATUS_SUCCESS :
CAIRO_STATUS_READ_ERROR;

I would be stricter:

return readBytes == length ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR;

Note that only works because the second parameter, size, is 1.

> Tools/ImageDiff/cairo/PlatformImageCairo.cpp:129
> +	       return writtenBytes ? CAIRO_STATUS_SUCCESS :
CAIRO_STATUS_WRITE_ERROR;

Ditto:

return writtenBytes == length ? CAIRO_STATUS_SUCCESS :
CAIRO_STATUS_WRITE_ERROR;