[webkit-reviews] review granted: [Bug 171448] Speedometer: Add an ES2015 TodoMVC implementation : [Attachment 308634] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 8 23:22:05 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Addy Osmani <addyo at chromium.org>'s
request for review:
Bug 171448: Speedometer: Add an ES2015 TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171448

Attachment 308634: Patch

https://bugs.webkit.org/attachment.cgi?id=308634&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 308634
  --> https://bugs.webkit.org/attachment.cgi?id=308634
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308634&action=review

> PerformanceTests/ChangeLog:7
> +	   Reviewed by NOBODY (OOPS!).
> +	   Adds ES2015 TodoMVC implementation for Speedometer

Again, please add a blank line between Reviewed by and this description.

> PerformanceTests/ChangeLog:11
> +	   (html,):

And remove these inline comments since we're just importing files and not
adding any inline comments.


More information about the webkit-reviews mailing list