[webkit-reviews] review granted: [Bug 171845] Update DocumentOrShadowRoot.idl to match specifications : [Attachment 309464] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 8 21:15:57 PDT 2017
Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 171845: Update DocumentOrShadowRoot.idl to match specifications
https://bugs.webkit.org/show_bug.cgi?id=171845
Attachment 309464: Patch
https://bugs.webkit.org/attachment.cgi?id=309464&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 309464
--> https://bugs.webkit.org/attachment.cgi?id=309464
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=309464&action=review
> Source/WebCore/dom/Document.idl:106
> + // FIXME: Should likely be moved to DocumentOrShadowRoot.
Not sure if "likely" is necessary given the current spec says so. We can remove
the comment if we change the spec.
More information about the webkit-reviews
mailing list