[webkit-reviews] review requested: [Bug 163412] REGRESSION: MessageEvent.source for bound postMessage() is wrong for same-origin iframe : [Attachment 309455] Patch and layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 8 18:34:30 PDT 2017


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 163412: REGRESSION: MessageEvent.source for bound postMessage() is wrong
for same-origin iframe
https://bugs.webkit.org/show_bug.cgi?id=163412

Attachment 309455: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=309455&action=review




--- Comment #26 from Daniel Bates <dbates at webkit.org> ---
Created attachment 309455

  --> https://bugs.webkit.org/attachment.cgi?id=309455&action=review

Patch and layout tests

Updated patch based on feedback from Geoffrey Garen and Saam Barati. With this
patch applied we compute the incumbent global object correctly for all WebIDL
callbacks and promise callbacks, including requestAnimationFrame(). I also
added more tests to cover these cases.


More information about the webkit-reviews mailing list