[webkit-reviews] review granted: [Bug 169421] Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices : [Attachment 309248] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 169421: Implement PlatformWebView::windowSnapshotImage and
createBitmapContextFromWebView for iOS devices
https://bugs.webkit.org/show_bug.cgi?id=169421

Attachment 309248: Patch

https://bugs.webkit.org/attachment.cgi?id=309248&action=review




--- Comment #30 from Tim Horton <thorton at apple.com> ---
Comment on attachment 309248
  --> https://bugs.webkit.org/attachment.cgi?id=309248
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309248&action=review

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:269
> +    [snapshotConfiguration setRect:NSMakeRect(0, 0, m_view.frame.size.width,
m_view.frame.size.height)];

CGRectMake

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:272
> +    [m_view takeSnapshotWithConfiguration:snapshotConfiguration.get()
completionHandler:^(UIImage* snapshotImage, NSError *error) {

Stars on the wrong side :)

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:278
> +    while (!isDone)
> +	   [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode
beforeDate:[NSDate distantPast]];

Don't we have a wrapper for this? If not, it's fine.