[webkit-reviews] review granted: [Bug 171816] Remove black background from video layer while in fullscreen. : [Attachment 309385] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 8 12:25:28 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 171816: Remove black background from video layer while in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=171816

Attachment 309385: Patch

https://bugs.webkit.org/attachment.cgi?id=309385&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 309385
  --> https://bugs.webkit.org/attachment.cgi?id=309385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309385&action=review

We should have a test for this. You may be able to add a test for this to an
existing API tests instead of writing a new test.

> Source/WebCore/ChangeLog:11
> +	   and back to black when it returns to inline to better fascilitate
fullsceen animations.

Nit: "fascilitate" => "facilitate"


More information about the webkit-reviews mailing list