[webkit-reviews] review granted: [Bug 171812] CoreAudioSharedUnit should own its configuration parameters : [Attachment 309380] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 171812: CoreAudioSharedUnit should own its configuration parameters
https://bugs.webkit.org/show_bug.cgi?id=171812

Attachment 309380: Patch

https://bugs.webkit.org/attachment.cgi?id=309380&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 309380
  --> https://bugs.webkit.org/attachment.cgi?id=309380
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309380&action=review

> Source/WebCore/ChangeLog:11
> +	   Adding sampleRate, volume and echoCancellation parameters to the
shared audio unit.
> +	   Setting default values when creating the shared audio unit and using
those for the creation of new sources.

Nit: "Adding" => "Add", "Setting" => "Set", "using" => "use"

> Source/WebCore/ChangeLog:14
> +	   Checking valid sample rates when trying to apply a sample rate.

Nit: "Checking" => "Check"