[webkit-reviews] review granted: [Bug 171775] DeferredPromise::callFunction() should clear any unhandled exceptions. : [Attachment 309293] proposed patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 171775: DeferredPromise::callFunction() should clear any unhandled
exceptions.
https://bugs.webkit.org/show_bug.cgi?id=171775

Attachment 309293: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=309293&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 309293
  --> https://bugs.webkit.org/attachment.cgi?id=309293
proposed patch.

r=me

Since there's no API to pass an exception to a client, I think it makes sense
to catch and clear the exception unconditionally. It's true that this might
lead to a broken webpage, but I can't see a way to improve upon that.