[webkit-reviews] review granted: [Bug 171809] Reduce PassRefPtr use : [Attachment 309368] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 171809: Reduce PassRefPtr use
https://bugs.webkit.org/show_bug.cgi?id=171809

Attachment 309368: Patch

https://bugs.webkit.org/attachment.cgi?id=309368&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 309368
  --> https://bugs.webkit.org/attachment.cgi?id=309368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309368&action=review

r=me with comments, please make sure all bots are happy.

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:355
> +	   AVPlayerLayer *destinationPlayerLayer =
static_cast<PlatformCALayerCocoa&>(newLayer.get()).avPlayerLayer();

Should be a downcast.

> Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp:54
>      visitedLinkTableControllerPtr = visitedLinkTableController.ptr();

This line seems useless?

> Source/WebKit2/WebProcess/WebPage/WebOpenPanelResultListener.h:57
>      RefPtr<WebCore::FileChooser> m_fileChooser;

Should be a Ref<>.