[webkit-reviews] review requested: [Bug 171799] WebAssembly: don't just emit extended offset adds for patch : [Attachment 309346] patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has asked  for review:
Bug 171799: WebAssembly: don't just emit extended offset adds for patch
https://bugs.webkit.org/show_bug.cgi?id=171799

Attachment 309346: patch

https://bugs.webkit.org/attachment.cgi?id=309346&action=review




--- Comment #1 from JF Bastien <jfbastien at apple.com> ---
Created attachment 309346

  --> https://bugs.webkit.org/attachment.cgi?id=309346&action=review

patch

pizlo had said:

(In reply to Filip Pizlo from comment #30)
> Comment on attachment 309022 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309022&action=review
> 
> > Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:80
> > +			     if (isPatch && inst.admitsExtendedOffsetAddr(arg))
{
> 
> I would drop the isPatch check