[webkit-reviews] review granted: [Bug 171770] [GTK] Cannot sign in with new Google sign-in page : [Attachment 309305] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 7 02:01:42 PDT 2017


Carlos Garcia Campos <cgarcia at igalia.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 171770: [GTK] Cannot sign in with new Google sign-in page
https://bugs.webkit.org/show_bug.cgi?id=171770

Attachment 309305: Patch

https://bugs.webkit.org/attachment.cgi?id=309305&action=review




--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 309305
  --> https://bugs.webkit.org/attachment.cgi?id=309305
Patch

I'm r+ and cq+'ing because this is important fix, but it should include a unit
tests, please add it in a follow up patch. Thanks for fixing this mess


More information about the webkit-reviews mailing list