[webkit-reviews] review granted: [Bug 171777] Align our IDL files with the latest DOM specification : [Attachment 309307] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 171777: Align our IDL files with the latest DOM specification
https://bugs.webkit.org/show_bug.cgi?id=171777

Attachment 309307: Patch

https://bugs.webkit.org/attachment.cgi?id=309307&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 309307
  --> https://bugs.webkit.org/attachment.cgi?id=309307
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309307&action=review

v.nice r=me

> Source/WebCore/dom/Document.idl:175
> +    // Non standard.
> +    Range caretRangeFromPoint(optional long x = 0, optional long y = 0);

I would note it has been superseded by caretPositionFromPoint, which we don't
yet implement.

> Source/WebCore/dom/Range.idl:64
> +    DOMString toString(); // FIXME: Should be stringifier once we support
it.

I believe we do support stringifier.  It's used in a number of other IDLs.

> Source/WebCore/dom/Range.idl:73
> +    // Non Standard API.

Might want to standardize on how you write "non standard".  In other places you
left off the API and made standard all lowercase.

> Source/WebCore/dom/Text.idl:25
> +    [NewObject, MayThrowException] Text splitText(unsigned long offset);

What happens when offset is 0? Does it really still return a new object?