[webkit-reviews] review granted: [Bug 171728] [MediaStream] r216197 caused some webrtc tests to fail : [Attachment 309270] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 6 09:38:07 PDT 2017


Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 171728: [MediaStream] r216197 caused some webrtc tests to fail
https://bugs.webkit.org/show_bug.cgi?id=171728

Attachment 309270: Patch

https://bugs.webkit.org/attachment.cgi?id=309270&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 309270
  --> https://bugs.webkit.org/attachment.cgi?id=309270
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309270&action=review

Thanks!

> Source/WebCore/ChangeLog:10
> +	   Renaming MediaStream::endStream by MediaStream::endCaptureTracks and
only stopping capture tracks.

Nit: "Renaming MediaStream::endStream by MediaStream::endCaptureTracks" =>
"Rename MediaStream::endStream to MediaStream::endCaptureTracks"

> Source/WebCore/ChangeLog:16
> +	   Adding the ability to have only one active capture source at a time
in a WebProcess.
> +	   This is done by keeping in its related factory the active capture
source.
> +	   When a new source is created and started, it replaces the active
capture source which becomes muted.
> +	   Using that mechanism for iOS.

Great idea, very nice!


More information about the webkit-reviews mailing list