[webkit-reviews] review granted: [Bug 171707] CallLinkInfos belonging to Wasm->JS stubs need to be informed when we clearCode() from all Executables : [Attachment 309190] patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 171707: CallLinkInfos belonging to Wasm->JS stubs need to be informed when
we clearCode() from all Executables
https://bugs.webkit.org/show_bug.cgi?id=171707

Attachment 309190: patch

https://bugs.webkit.org/attachment.cgi?id=309190&action=review




--- Comment #7 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 309190
  --> https://bugs.webkit.org/attachment.cgi?id=309190
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309190&action=review

Looks good!

> Source/JavaScriptCore/runtime/VM.cpp:176
> +    , webAssemblyCodeBlockSubspace("JSWebAssemblyCodeBlockSubspace", heap)

I've been calling these "Spaces" and not "Subspaces".  It's a subspace of the
heap but it's the space of web assembly code blocks.  But, I don't feel very
strongly about this.  For example, I would be in favor of renaming all of them
to have the "Subspace" suffix (including the two in WebCore).  I'm a bit less
sure about having the naming be inconsistent.