[webkit-reviews] review denied: [Bug 171761] Unprefix unicode-bidi CSS values : [Attachment 309250] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 171761: Unprefix unicode-bidi CSS values
https://bugs.webkit.org/show_bug.cgi?id=171761

Attachment 309250: Patch

https://bugs.webkit.org/attachment.cgi?id=309250&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 309250
  --> https://bugs.webkit.org/attachment.cgi?id=309250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309250&action=review

> Source/WebCore/css/CSSProperties.json:3510
> +		   "isolate",
> +		   "isolate-override",
> +		   "plaintext",
>		   {
>		       "value": "-webkit-isolate",
>		       "status": "experimental",

Can you fix the JSON to be like:

		{
		    "value": "isolate",
		    "url":
"https://www.w3.org/TR/css-writing-modes-3/#valdef-unicode-bidi-isolate"
		},
		{
		    "value": "-webkit-isolate",
		    "status": "deprecated"
		},
etc?

> Source/WebCore/css/parser/CSSParserFastPaths.cpp:659
> +	       || valueID == CSSValueBidiOverride || valueID == CSSValueIsolate
> +	       || valueID == CSSValueIsolateOverride || valueID ==
CSSValuePlaintext
> +	       || valueID == CSSValueWebkitIsolate || valueID ==
CSSValueWebkitIsolateOverride
> +	       || valueID == CSSValueWebkitPlaintext;

Could you group the prefixed and unprefixed in pairs please.

> LayoutTests/ChangeLog:9
> +	   Import W3C's internationalization tests from
> +	  
https://www.w3.org/International/tests/repo/results/writing-modes-bidi

I think these should go into LayoutTests/imported/