[webkit-reviews] review granted: [Bug 171737] Move trivial String prototype functions to JS builtins : [Attachment 309223] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 171737: Move trivial String prototype functions to JS builtins
https://bugs.webkit.org/show_bug.cgi?id=171737

Attachment 309223: Patch

https://bugs.webkit.org/attachment.cgi?id=309223&action=review




--- Comment #33 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 309223
  --> https://bugs.webkit.org/attachment.cgi?id=309223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309223&action=review

> Source/JavaScriptCore/builtins/StringPrototype.js:312
> +    if (string == null)

Do we care about document.all here counting as undefined?